walterddr commented on code in PR #10779: URL: https://github.com/apache/pinot/pull/10779#discussion_r1198024063
########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/pipeline/PipelineBreakerVisitor.java: ########## @@ -0,0 +1,48 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.runtime.plan.pipeline; + +import org.apache.pinot.query.planner.plannode.DefaultPostOrderTraversalVisitor; +import org.apache.pinot.query.planner.plannode.MailboxReceiveNode; +import org.apache.pinot.query.planner.plannode.PlanNode; +import org.apache.pinot.query.planner.plannode.PlanNodeVisitor; + + +public class PipelineBreakerVisitor extends DefaultPostOrderTraversalVisitor<Void, PipelineBreakerContext> { + private static final PlanNodeVisitor<Void, PipelineBreakerContext> INSTANCE = new PipelineBreakerVisitor(); + + public static void visitPlanRoot(PlanNode root, PipelineBreakerContext context) { + root.visit(PipelineBreakerVisitor.INSTANCE, context); + } + + @Override + public Void process(PlanNode planNode, PipelineBreakerContext context) { + context.visitedNewPlanNode(planNode); + return null; + } + + @Override + public Void visitMailboxReceive(MailboxReceiveNode node, PipelineBreakerContext context) { + process(node, context); + // TODO: actually implement pipeline breaker attribute in PlanNode + // currently all mailbox receive node from leaf stage is considered as pipeline breaker node. + context.addPipelineBreaker(node); + return null; Review Comment: TODO: @xiangfu0 we need a pipeline breaker indicator flag in planner to tell "this is a pipeline breaker node" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
