walterddr commented on code in PR #10779:
URL: https://github.com/apache/pinot/pull/10779#discussion_r1198011452
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##########
@@ -180,12 +214,12 @@ public ExecutorService getQueryRunnerExecutorService() {
}
private OpChain compileLeafStage(DistributedStagePlan distributedStagePlan,
Map<String, String> requestMetadataMap,
- long timeoutMs, long deadlineMs, long requestId) {
+ PipelineBreakerContext pipelineBreakerContext, long timeoutMs, long
deadlineMs, long requestId) {
Review Comment:
TODO: consider if this is the best way to pass around extra info for each
visitor/builder
we already have
- 3 plan contexts (1 more is added in this PR)
- 3 visitors (1 more is added in this PR)
all of these needs to create slightly different visitor context.
this means changing the function signature like this line will impact 10+
places, most of these are passthrough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
