ankitsultana commented on code in PR #10752:
URL: https://github.com/apache/pinot/pull/10752#discussion_r1192543509
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1438,9 +1441,13 @@ public void uploadToDeepStoreIfMissing(TableConfig
tableConfig, List<SegmentZKMe
// Randomly ask one server to upload
URI uri = peerSegmentURIs.get(RANDOM.nextInt(peerSegmentURIs.size()));
String serverUploadRequestUrl = StringUtil.join("/", uri.toString(),
"upload");
+ serverUploadRequestUrl =
+ String.format("%s?uploadTimeoutMs=%d", serverUploadRequestUrl,
_deepstoreUploadRetryTimeoutMs);
LOGGER.info("Ask server to upload LLC segment {} to deep store by this
path: {}", segmentName,
serverUploadRequestUrl);
- String segmentDownloadUrl =
_fileUploadDownloadClient.uploadToSegmentStore(serverUploadRequestUrl);
+ String tempSegmentDownloadUrl =
_fileUploadDownloadClient.uploadToSegmentStore(serverUploadRequestUrl);
Review Comment:
Just a note: the http-connection timeout used here is 10 minutes. For all
practical purposes, this should work fine.
@walterddr : lmk if we should set this to be equal to
`_deepstoreUploadRetryTimeoutMs`. That would require adding another method to
the FileUploadDownloadClient. Since that class is already quite large, I was
hesitant on adding another method there (since it doesn't seem super necessary
to have).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
