jasperjiaguo commented on code in PR #10636:
URL: https://github.com/apache/pinot/pull/10636#discussion_r1186960260
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java:
##########
@@ -325,6 +325,18 @@ public static AggregationFunction
getAggregationFunction(FunctionContext functio
return new FourthMomentAggregationFunction(firstArgument,
FourthMomentAggregationFunction.Type.KURTOSIS);
case FOURTHMOMENT:
return new FourthMomentAggregationFunction(firstArgument,
FourthMomentAggregationFunction.Type.MOMENT);
+ case PINOTPARENTAGGREGATIONARGMAX:
+ return new ParentArgMinMaxAggregationFunction(arguments, true);
+ case PINOTPARENTAGGREGATIONARGMIN:
+ return new ParentArgMinMaxAggregationFunction(arguments, false);
+ case PINOTCHILDAGGREGATIONARGMAX:
+ return new ChildArgMinMaxAggregationFunction(arguments, true);
+ case PINOTCHILDAGGREGATIONARGMIN:
Review Comment:
@siddharthteotia in that case we would need to use one specific argument in
the argument list to denote if the function is parent or children and the
factory here would need to look into the argument details, which IMO is not
very clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
