siddharthteotia commented on code in PR #10636:
URL: https://github.com/apache/pinot/pull/10636#discussion_r1186957132
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -972,4 +974,11 @@ public static class Range {
public static class IdealState {
public static final String HYBRID_TABLE_TIME_BOUNDARY =
"HYBRID_TABLE_TIME_BOUNDARY";
}
+
+ public static class RewriterConstants {
Review Comment:
I wonder why should this be defined in `CommonConstants` where we typically
define Broker or Server instance level config constants ? Can this be taken
inside rewriter as public constants ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
