jasperjiaguo commented on code in PR #10636:
URL: https://github.com/apache/pinot/pull/10636#discussion_r1186963059
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -972,4 +974,11 @@ public static class Range {
public static class IdealState {
public static final String HYBRID_TABLE_TIME_BOUNDARY =
"HYBRID_TABLE_TIME_BOUNDARY";
}
+
+ public static class RewriterConstants {
+ public static final String PARENT_AGGREGATION_NAME_PREFIX =
"pinotparentaggregation";
+ public static final String CHILD_AGGREGATION_NAME_PREFIX =
"pinotchildaggregation";
+ public static final String CHILD_AGGREGATION_SEPERATOR = "@";
+ public static final String CHILD_KEY_SEPERATOR = "_";
Review Comment:
```
/**
* The name of the column as follows:
* CHILD_AGGREGATION_NAME_PREFIX + actual function type + operands +
CHILD_AGGREGATION_SEPERATOR
* + actual function type + parent aggregation function id +
CHILD_KEY_SEPERATOR + column key in parent function
* e.g. if the child aggregation function is "argmax(0,a,b,x)", the name
of the column is
* "pinotchildaggregationargmax(a,b,x)@argmax0_x"
*/
```
To easily associate the child aggregation function with it's parents and
extract the result with key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
