jugomezv commented on code in PR #10418:
URL: https://github.com/apache/pinot/pull/10418#discussion_r1149826701
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##########
@@ -214,12 +214,20 @@ public void updateIngestionDelay(long ingestionTimeMs,
long firstStreamIngestion
// Do not update the ingestion delay metrics during server startup period
return;
}
+ if ((ingestionTimeMs < 0) && (firstStreamIngestionTimeMs < 0)) {
Review Comment:
&& is the intention:
Case 1 Stream does not support ingestion delay nor end to end delay: we bail
out early and do not record anything.
If either ingestion delay or end to end ingestion delay we do record the
times but only publish the one that has value larger than zero.
I think in the previous incarnation the code must have been dumping negative
metrics or very large number for any ingestion delay not supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
