jugomezv commented on code in PR #10418:
URL: https://github.com/apache/pinot/pull/10418#discussion_r1146811126
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1574,12 +1586,24 @@ private void createPartitionMetadataProvider(String
reason) {
private void updateIngestionDelay(int indexedMessageCount) {
if ((indexedMessageCount > 0) && (_lastRowMetadata != null)) {
// Record Ingestion delay for this partition
-
_realtimeTableDataManager.updateIngestionDelay(_lastRowMetadata.getRecordIngestionTimeMs(),
- _lastRowMetadata.getFirstStreamRecordIngestionTimeMs(),
- _partitionGroupId);
+ updateIngestionDelay(_lastRowMetadata);
}
}
+ private void updateIngestionDelay(RowMetadata metadata) {
+
_realtimeTableDataManager.updateIngestionDelay(metadata.getRecordIngestionTimeMs(),
+ metadata.getFirstStreamRecordIngestionTimeMs(),
Review Comment:
This is a good point, but the checking belongs in the core method in the
IngestionDelayTracker class. I have modified it in such a way we don't publish
the metric that comes with negative values in the ingestion tracker so that no
matter where we invoke update ingestion delay it will do the right thing.
Now we support proper publishing of metrics if only ingestion delay is
supported, or only end to end is supported or both are unsupported, or both are
supported, or both are unsupported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
