navina commented on code in PR #10418:
URL: https://github.com/apache/pinot/pull/10418#discussion_r1151423143
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -618,14 +618,18 @@ private boolean processStreamEvents(MessageBatch
messagesAndOffsets, long idlePi
updateCurrentDocumentCountMetrics();
if (messagesAndOffsets.getUnfilteredMessageCount() > 0) {
_hasMessagesFetched = true;
+ if (messageCount == 0) {
+ // If we did not get any events but got some unfiltered messages, we
attempt to estimate the ingestion
Review Comment:
I don't think the ovehead is a lot and it definitely trumps the readability
of the code. There are 3-4 types of counts that we track here in a very C style
code. Hence, the suggetion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
