navina commented on PR #10418: URL: https://github.com/apache/pinot/pull/10418#issuecomment-1478437298
> A new API work. Does it make sense to still merge this as is in the meantime? It's still a fairly new metric. I recommend waiting on the API based change as setting ingestion delay to 0 when all records are filtered is not correct. The delay should still consider the timestamp on the filtered records. If the fix was not performant, I wouldn't mind merging and fixing forward. But this pertains to correctness of the solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
