jadami10 commented on PR #10418: URL: https://github.com/apache/pinot/pull/10418#issuecomment-1476238610
I want to +1 this solution as is since this also affects us for every table. I agree it's not functionally correct, but it's functionally better than what we have today. A buggy, ever increasing metric is impossible to reason about; you don't know if you're really lagging or there's just no data. But if the metric just dips to 0 transiently, we can abstract that away in a metrics system by either 1) taking a "max" over the time period or 2) just filtering out the 0s. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
