gortiz commented on PR #10191: URL: https://github.com/apache/pinot/pull/10191#issuecomment-1461684549
> Should we rename this method to getName()? I think `id` is a better description for this concept. Unlike `name`s, `id`s usually imply unicity and stability in time, while `name` is usually a term more focused on how to present the information to the user and they usually can change. Also, all other branches are already using `id` so I would prefer to do not have to change them again unless you really think `name` is better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
