gortiz commented on PR #10191: URL: https://github.com/apache/pinot/pull/10191#issuecomment-1451425505
> IMO it is okay to have the _index suffix for inverted, forward etc. We don't have bloom_index (it is bloom_filter), dictionary_index which is controversial. IMO that is cheep, repetitive (we define these objects as keys in `indexes`) and in general a bad user experience that is very easy to solve (in fact, it is solved with this PR). We can discuss whether we want to use other names on methods (maybe not calling them `getId` and `getName`), but forcing users to use these not that friendly names when it is easy to let them use better names is not a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
