Jackie-Jiang commented on code in PR #10169:
URL: https://github.com/apache/pinot/pull/10169#discussion_r1085982212
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/streaming/StreamingSelectionOnlyCombineOperator.java:
##########
@@ -47,13 +47,17 @@ public String toExplainString() {
}
@Override
- protected boolean isOperatorSatisfied(SelectionResultsBlock resultsBlock) {
- long numRowsCollected =
_numRowsCollected.addAndGet(resultsBlock.getNumRows());
- return numRowsCollected >= _limit;
+ protected boolean isChildOperatorSingleBlock() {
+ return false;
Review Comment:
This is for the child operator (e.g. AggregationOperator) which is not the
CombineOperator. Most of the operators (executor on a single segment) returns a
single block, with the only exception of `StreamingSelectionOnlyOperator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
