siddharthteotia commented on code in PR #10169:
URL: https://github.com/apache/pinot/pull/10169#discussion_r1084806337
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/streaming/StreamingSelectionOnlyCombineOperator.java:
##########
@@ -47,13 +47,17 @@ public String toExplainString() {
}
@Override
- protected boolean isOperatorSatisfied(SelectionResultsBlock resultsBlock) {
- long numRowsCollected =
_numRowsCollected.addAndGet(resultsBlock.getNumRows());
- return numRowsCollected >= _limit;
+ protected boolean isChildOperatorSingleBlock() {
+ return false;
Review Comment:
Shouldn't this return to false at `BaseStreamingCombineOperator` level
itself assuming single block here non-streaming combine operator that merge
into a single block ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
