jasperjiaguo commented on code in PR #10169:
URL: https://github.com/apache/pinot/pull/10169#discussion_r1084768322
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/InstanceResponseOperator.java:
##########
@@ -111,6 +116,10 @@ private BaseResultsBlock getCombinedResults() {
try {
prefetchAll();
return _combineOperator.nextBlock();
+ } catch (EarlyTerminationException e) {
+ Exception killedErrorMsg =
Tracing.getThreadAccountant().getErrorStatus();
+ return new ExceptionResultsBlock(new QueryCancelledException(
+ "Cancelled while combining results" + (killedErrorMsg == null ?
StringUtils.EMPTY : " " + killedErrorMsg)));
Review Comment:
@Jackie-Jiang IIUC in the runner thread, `InstanceResponseOperator` calls
`_combineOperator.nextBlock()`; where the `InterruptedException` is folded into
`EarlyTerminationException`, right?
It should be fine this way @siddharthteotia as long as
`Tracing.getThreadAccountant().getErrorStatus();` get called eventually. It
would be able to collect the error status from the accountant, as the query
killing message is not carried in `InterruptedException` but in
`Tracing.getThreadAccountant().getErrorStatus()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
