agavra commented on code in PR #10120: URL: https://github.com/apache/pinot/pull/10120#discussion_r1073983925
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/function/InternalReduceFunctions.java: ########## @@ -0,0 +1,45 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.pinot.segment.local.function; + +import org.apache.pinot.segment.local.customobject.PinotFourthMoment; +import org.apache.pinot.spi.annotations.ScalarFunction; + + +/** + * This class contains functions that are necessary for the multistage engine + * aggregations that need to be reduced after the initial aggregation to get + * + */ +public class InternalReduceFunctions { Review Comment: It relies on the `PinotFourthMoment` class, which is in `pinot-segment-local` because that's what the aggregate uses internally and that's where all the other custom objects are. I can move it to any package that depends on `pinot-segment-local` if you have any suggestions of where's a better place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
