agavra commented on code in PR #10120:
URL: https://github.com/apache/pinot/pull/10120#discussion_r1073981132
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java:
##########
@@ -65,6 +65,7 @@ public enum AggregationFunctionType {
STDDEVSAMP("stdDevSamp"),
SKEWNESS("skewness"),
KURTOSIS("kurtosis"),
+ FOURTHMOMENT("fourthmoment"),
Review Comment:
calcite will literally rewrite the query into
`SKEWNESSREDUCE(FOURTHMOMENT(col))`, which means the engine needs to know how
to execute this - so I register it as `FOURTHMOMENT` directly. I'm not sure of
a way to avoid exposing this altogether, open to suggestions though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
