[GitHub] [pinot] agavra commented on a diff in pull request #10120: [multistage] support aggregations that require intermediate representations

[GitBox]

agavra commented on code in PR #10120:
URL: https://github.com/apache/pinot/pull/10120#discussion_r1072413816


##########
pinot-common/src/main/java/org/apache/pinot/common/datablock/DataBlockUtils.java:
##########
@@ -250,6 +252,9 @@ public static Object[] extractRowFromDataBlock(DataBlock 
dataBlock, int rowId, D
           case TIMESTAMP_ARRAY:
             row[colId] = 
DataSchema.ColumnDataType.TIMESTAMP_ARRAY.convert(dataBlock.getLongArray(rowId, 
colId));
             break;
+          case OBJECT:
+            row[colId] = 
customObjectSerde.apply(dataBlock.getCustomObject(rowId, colId));

Review Comment:
   sorry not sure what you mean here? I pass it in because of the unfortunate 
module system which means I can't pass in the serde itself here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org