walterddr commented on code in PR #10123: URL: https://github.com/apache/pinot/pull/10123#discussion_r1072815107
########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/V2Operator.java: ########## @@ -0,0 +1,49 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.runtime.operator; + +import java.util.List; +import org.apache.pinot.core.common.Operator; +import org.apache.pinot.core.operator.BaseOperator; +import org.apache.pinot.query.runtime.blocks.TransferableBlock; +import org.slf4j.LoggerFactory; + + +public abstract class V2Operator extends BaseOperator<TransferableBlock> implements AutoCloseable { + private static final org.slf4j.Logger LOGGER = LoggerFactory.getLogger(MailboxReceiveOperator.class); + + @Override + public List<Operator> getChildOperators() { Review Comment: +1 ########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/V2Operator.java: ########## @@ -0,0 +1,49 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.runtime.operator; + +import java.util.List; +import org.apache.pinot.core.common.Operator; +import org.apache.pinot.core.operator.BaseOperator; +import org.apache.pinot.query.runtime.blocks.TransferableBlock; +import org.slf4j.LoggerFactory; + + +public abstract class V2Operator extends BaseOperator<TransferableBlock> implements AutoCloseable { + private static final org.slf4j.Logger LOGGER = LoggerFactory.getLogger(MailboxReceiveOperator.class); + + @Override + public List<Operator> getChildOperators() { + throw new UnsupportedOperationException(); + } + + abstract List<V2Operator> getV2ChildOperators(); + + @Override + public void close() { Review Comment: echo back to my shutdown comment. should we put a timeout in case shutdown is stuck? ########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/RoundRobinScheduler.java: ########## @@ -131,6 +138,20 @@ public int size() { return _ready.size() + _available.size(); } + @Override + public void shutDown() { + if (_isShutDown) { + return; + } + while (!_ready.isEmpty()) { + _ready.poll().close(); + } + while (!_available.isEmpty()) { + _available.poll()._opChain.close(); + } Review Comment: should we add timeout for _opChain.close() ? is it possible opChain close to be stuck? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
