61yao commented on code in PR #10123:
URL: https://github.com/apache/pinot/pull/10123#discussion_r1072511341


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/RoundRobinScheduler.java:
##########
@@ -79,6 +83,9 @@ public RoundRobinScheduler(long releaseTimeoutMs, 
Supplier<Long> ticker) {
 
   @Override
   public void register(OpChain operatorChain, boolean isNew) {
+    if (_isShutDown) {

Review Comment:
   This class is not thread safe. Please see the java decoration and other 
implementation. It is caller's responsibility to make thread safe call to this 
call. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to