61yao commented on code in PR #10123:
URL: https://github.com/apache/pinot/pull/10123#discussion_r1072859645
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/RoundRobinScheduler.java:
##########
@@ -131,6 +138,20 @@ public int size() {
return _ready.size() + _available.size();
}
+ @Override
+ public void shutDown() {
+ if (_isShutDown) {
+ return;
+ }
+ while (!_ready.isEmpty()) {
+ _ready.poll().close();
+ }
+ while (!_available.isEmpty()) {
+ _available.poll()._opChain.close();
+ }
Review Comment:
See the comments above. Added a TODO for timeout consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
