walterddr commented on code in PR #10117:
URL: https://github.com/apache/pinot/pull/10117#discussion_r1069699612
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryServer.java:
##########
@@ -45,13 +48,16 @@ public class QueryServer extends
PinotQueryWorkerGrpc.PinotQueryWorkerImplBase {
private final Server _server;
private final QueryRunner _queryRunner;
+ private final ExecutorService _executorService;
public QueryServer(int port, QueryRunner queryRunner) {
_server = ServerBuilder.forPort(port).addService(this).build();
_queryRunner = queryRunner;
+ _executorService =
Executors.newFixedThreadPool(ResourceManager.DEFAULT_QUERY_RUNNER_THREADS,
Review Comment:
that's a good point! actually i double check the code it should reuse the
same threadpool but allocate number of threads in an additive fashion. will
reuse the same threadpool here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
