walterddr commented on code in PR #10117:
URL: https://github.com/apache/pinot/pull/10117#discussion_r1068806510
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryServer.java:
##########
@@ -45,13 +48,16 @@ public class QueryServer extends
PinotQueryWorkerGrpc.PinotQueryWorkerImplBase {
private final Server _server;
private final QueryRunner _queryRunner;
+ private final ExecutorService _executorService;
public QueryServer(int port, QueryRunner queryRunner) {
_server = ServerBuilder.forPort(port).addService(this).build();
_queryRunner = queryRunner;
+ _executorService =
Executors.newFixedThreadPool(ResourceManager.DEFAULT_QUERY_RUNNER_THREADS,
Review Comment:
yes I can reuse the worker pool. the reason why I did this is b/c there's a
RUNNER thread and WORKER thread in ResourceManager for V1.
- RUNNER is used for planMaker and running the instance and combine operator
- WORKER is used for executing individual tasks within combine operator
I was trying to do the same. but I can definitely reuse either the RUNNER
from V1 or WORKER from V2. i just don't know what's the best abstraction so i
choose to follow what V1 has
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
