saurabhd336 commented on code in PR #10088:
URL: https://github.com/apache/pinot/pull/10088#discussion_r1068999095


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3610,6 +3628,21 @@ private void waitForSegmentsBecomeOnline(String 
tableNameWithType, Set<String> s
             tableNameWithType, segmentsToCheck));
   }
 
+  public Set<String> getSegmentsFromIdealStateMatchingState(String 
tableNameWithType,

Review Comment:
   Ack



##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/IngestionConfigHybridIntegrationTest.java:
##########
@@ -217,6 +222,46 @@ public void testQueries()
     Assert.assertEquals(response.get("resultTable").get("rows").size(), 0);
   }
 
+  @Test
+  public void testForceCommit()

Review Comment:
   Ack



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to