jayeshchoudhary commented on code in PR #10088:
URL: https://github.com/apache/pinot/pull/10088#discussion_r1066749008
##########
pinot-controller/src/main/resources/app/pages/TenantDetails.tsx:
##########
@@ -384,7 +384,7 @@ const TenantPageDetails = ({ match }:
RouteComponentProps<Props>) => {
setShowReloadStatusModal(true);
const [reloadStatusData, tableJobsData] = await Promise.all([
PinotMethodUtils.reloadStatusOp(tableName, tableType),
- PinotMethodUtils.fetchTableJobs(tableName),
+ PinotMethodUtils.fetchTableJobs(tableName,
"RELOAD_SEGMENT,RELOAD_ALL_SEGMENTS"),
Review Comment:
Actually, there is a better way to do this.
We can declare a type with all the reload job types and pass array of types
in the function
And when making api call do
```js
let searchParams = new URLSearchParams();
if(jobTypes) {
jobTypes.forEach((jobType) => {
searchParams.append('jobTypes', jobType);
})
}
axios.get('http://server/status', {params: searchParams});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
