saurabhd336 commented on code in PR #10088:
URL: https://github.com/apache/pinot/pull/10088#discussion_r1066738674
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -2062,13 +2064,15 @@ public Map<String, String>
getControllerJobZKMetadata(String jobId) {
* @param tableNameWithType the table for which jobs are to be fetched
* @return A Map of jobId to job properties
*/
- public Map<String, Map<String, String>> getAllJobsForTable(String
tableNameWithType) {
+ public Map<String, Map<String, String>> getAllJobsForTable(String
tableNameWithType, Set<String> jobTypesToFilter) {
Review Comment:
Ack
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -2094,7 +2098,21 @@ public boolean addNewReloadSegmentJob(String
tableNameWithType, String segmentNa
jobMetadata.put(CommonConstants.ControllerJob.SUBMISSION_TIME_MS,
Long.toString(System.currentTimeMillis()));
jobMetadata.put(CommonConstants.ControllerJob.MESSAGE_COUNT,
Integer.toString(numMessagesSent));
jobMetadata.put(CommonConstants.ControllerJob.SEGMENT_RELOAD_JOB_SEGMENT_NAME,
segmentName);
- return addReloadJobToZK(jobId, jobMetadata);
+ return addControllerJobToZK(jobId, jobMetadata);
+ }
+
+ public boolean addNewForceCommitJob(String tableNameWithType, String jobId,
Set<String> consumingSegmentsCommitted)
+ throws JsonProcessingException {
+ Map<String, String> jobMetadata = new HashMap<>();
+ jobMetadata.put(CommonConstants.ControllerJob.JOB_ID, jobId);
+ jobMetadata.put(CommonConstants.ControllerJob.TABLE_NAME_WITH_TYPE,
tableNameWithType);
+ jobMetadata.put(CommonConstants.ControllerJob.JOB_TYPE,
ControllerJobType.FORCE_COMMIT.toString());
+ jobMetadata.put(CommonConstants.ControllerJob.SUBMISSION_TIME_MS,
Long.toString(System.currentTimeMillis()));
+ jobMetadata.put(CommonConstants.ControllerJob.MESSAGE_COUNT,
Integer.toString(consumingSegmentsCommitted.size()));
Review Comment:
Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
