siddharthteotia commented on code in PR #10006:
URL: https://github.com/apache/pinot/pull/10006#discussion_r1068827341
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/streaming/StreamingInstanceResponseOperator.java:
##########
@@ -42,17 +49,41 @@ public
StreamingInstanceResponseOperator(BaseCombineOperator<?> combinedOperator
_streamObserver = streamObserver;
}
+ @SuppressWarnings("rawtypes")
@Override
protected InstanceResponseBlock getNextBlock() {
- InstanceResponseBlock responseBlock = super.getNextBlock();
- InstanceResponseBlock metadataOnlyResponseBlock =
responseBlock.toMetadataOnlyResponseBlock();
+ prefetchAll();
+ BaseResultsBlock combinedResult;
try {
-
_streamObserver.onNext(StreamingResponseUtils.getDataResponse(responseBlock.toDataOnlyDataTable()));
+ ((BaseStreamBlockCombineOperator) _combineOperator).start();
+ combinedResult = _combineOperator.nextBlock();
+ while (!(combinedResult instanceof MetadataResultsBlock)) {
+ if (combinedResult instanceof ExceptionResultsBlock) {
+ return new InstanceResponseBlock(combinedResult, _queryContext);
+ } else {
+ sendBlock(combinedResult);
+ }
+ combinedResult = _combineOperator.nextBlock();
+ }
} catch (IOException e) {
- metadataOnlyResponseBlock.addException(
+ InstanceResponseBlock exceptionResultBlock = new InstanceResponseBlock();
+ exceptionResultBlock.addException(
QueryException.getException(QueryException.DATA_TABLE_SERIALIZATION_ERROR, e));
+ return exceptionResultBlock;
+ } finally {
+ ((BaseStreamBlockCombineOperator) _combineOperator).stop();
+ releaseAll();
}
// return a metadata-only block.
Review Comment:
(nit) this comment is probably no longer applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
