siddharthteotia commented on code in PR #10006:
URL: https://github.com/apache/pinot/pull/10006#discussion_r1068808800
##########
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java:
##########
@@ -175,35 +179,54 @@ public List<Operator> callJob() {
}
}
- if (_streamObserver != null &&
QueryContextUtils.isSelectionOnlyQuery(_queryContext)) {
- // Streaming query (only support selection only)
- return new StreamingSelectionOnlyCombineOperator(operators,
_queryContext, _executorService, _streamObserver);
- }
- if (QueryContextUtils.isAggregationQuery(_queryContext)) {
- if (_queryContext.getGroupByExpressions() == null) {
- // Aggregation only
- return new AggregationCombineOperator(operators, _queryContext,
_executorService);
+ if (_streamObserver != null) {
Review Comment:
This is not related to / introduced by this PR but if possible please
consider splitting this into 1-2 functions. The long if-else chain looks
unreadable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
