siddharthteotia commented on code in PR #10006:
URL: https://github.com/apache/pinot/pull/10006#discussion_r1068811492
##########
pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java:
##########
@@ -264,17 +264,9 @@ public Plan makeStreamingInstancePlan(List<IndexSegment>
indexSegments, QueryCon
planNodes.add(makeStreamingSegmentPlanNode(indexSegment, queryContext));
}
CombinePlanNode combinePlanNode = new CombinePlanNode(planNodes,
queryContext, executorService, streamObserver);
- if (QueryContextUtils.isSelectionOnlyQuery(queryContext)) {
- // selection-only is streamed in StreamingSelectionPlanNode --> here
only metadata block is returned.
- return new GlobalPlanImplV0(
- new InstanceResponsePlanNode(combinePlanNode, indexSegments,
Collections.emptyList(), queryContext));
- } else {
- // non-selection-only requires a StreamingInstanceResponsePlanNode to
stream data block back and metadata block
- // as final return.
- return new GlobalPlanImplV0(
- new StreamingInstanceResponsePlanNode(combinePlanNode,
indexSegments, Collections.emptyList(), queryContext,
- streamObserver));
- }
+ return new GlobalPlanImplV0(
+ new StreamingInstanceResponsePlanNode(combinePlanNode, indexSegments,
Collections.emptyList(), queryContext,
Review Comment:
Not sure I follow why this gets explicitly hard-coded to Streaming for
everything ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
