jugomezv commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1060833470


##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java:
##########
@@ -138,6 +139,11 @@ public void onBecomeOfflineFromConsuming(Message message, 
NotificationContext co
     @Transition(from = "CONSUMING", to = "DROPPED")
     public void onBecomeDroppedFromConsuming(Message message, 
NotificationContext context) {
       
_logger.info("SegmentOnlineOfflineStateModel.onBecomeDroppedFromConsuming() : " 
+ message);
+      String realtimeTableName = message.getResourceName();

Review Comment:
   I think you are referring to 
[this](https://github.com/apache/pinot/issues/10049), I am not addressing this 
here as this change is already large enough and it is not good idea to mix with 
other issues. The TOD has been placed in the code and the issue opened. I will 
address in a different PR. If this was not what you are referring please 
elaborate and reopen the comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to