mcvsubbu commented on code in PR #9994:
URL: https://github.com/apache/pinot/pull/9994#discussion_r1060827634
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -613,7 +613,7 @@ private boolean processStreamEvents(MessageBatch
messagesAndOffsets, long idlePi
_segmentLogger.debug("empty batch received - sleeping for {}ms",
idlePipeSleepTimeMillis);
}
// Record Pinot ingestion delay as zero since we are up-to-date and no
new events
- _realtimeTableDataManager.updateIngestionDelay(0,
System.currentTimeMillis(), _partitionGroupId);
+ setIngestionDelayToZero();
Review Comment:
Other than adding an extra method call, is there any change here?
Instead, if we call `updateIngestionDelay(0, currentTime, partiongroupId`,
can we not handle all the ingstion delay specific logic inside that method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
