mcvsubbu commented on code in PR #9994: URL: https://github.com/apache/pinot/pull/9994#discussion_r1055750820
########## pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java: ########## @@ -91,6 +92,16 @@ public void onBecomeOnlineFromConsuming(Message message, NotificationContext con TableDataManager tableDataManager = _instanceDataManager.getTableDataManager(realtimeTableName); Preconditions.checkNotNull(tableDataManager); + if (tableDataManager instanceof RealtimeTableDataManager) { Review Comment: You can add a method in TableDataManager interface with a default implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org