jugomezv commented on code in PR #9994: URL: https://github.com/apache/pinot/pull/9994#discussion_r1054696833
########## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java: ########## @@ -212,6 +217,63 @@ protected void doShutdown() { if (_leaseExtender != null) { _leaseExtender.shutDown(); } + // Make sure we do metric cleanup when we shutdown the table. + if (_consumptionDelayTracker != null) { + _consumptionDelayTracker.shutdown(); + } + // Now that segments can't report metric destroy metric for this table + _serverMetrics.removeTableGauge(_tableNameWithType, ServerGauge.MAX_PINOT_CONSUMPTION_DELAY_MS); + } + + /* + * Method to handle CONSUMING->DROPPED transition. + * + * @param partitionGroupId Partition id that we must stop tracking on this server. + */ + public void stopTrackingPartitionDelay(long partitionGroupId) { Review Comment: Yes got this in my env, somehow missed my last push -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org