[GitHub] [pinot] KKcorps commented on a diff in pull request #9825: Allow segment upload via Metadata in MergeRollup Minion task

[GitBox]

KKcorps commented on code in PR #9825:
URL: https://github.com/apache/pinot/pull/9825#discussion_r1036047120


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/SegmentPushUtils.java:
##########
@@ -97,6 +97,49 @@ public static URI generateSegmentTarURI(URI dirURI, URI 
fileURI, String prefix,
   public static void pushSegments(SegmentGenerationJobSpec spec, PinotFS 
fileSystem, List<String> tarFilePaths)
       throws RetriableOperationException, AttemptsExceededException {
     String tableName = spec.getTableSpec().getTableName();
+    AuthProvider authProvider = 
AuthProviderUtils.makeAuthProvider(spec.getAuthToken());

Review Comment:
   We need to pass this custom header in the new flow
   Older methods don't allow passing new headers
   ```java
   // Set segment ZK metadata custom map modifier into HTTP header to modify 
the segment ZK metadata
   SegmentZKMetadataCustomMapModifier segmentZKMetadataCustomMapModifier =
       getSegmentZKMetadataCustomMapModifier(pinotTaskConfig, 
segmentConversionResult);
   Header segmentZKMetadataCustomMapModifierHeader =
       new 
BasicHeader(FileUploadDownloadClient.CustomHeaders.SEGMENT_ZK_METADATA_CUSTOM_MAP_MODIFIER,
           segmentZKMetadataCustomMapModifier.toJsonString());
   ```                



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org