zhtaoxiang commented on code in PR #9825:
URL: https://github.com/apache/pinot/pull/9825#discussion_r1026701592
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java:
##########
@@ -571,6 +577,40 @@ private List<PinotTaskConfig>
createPinotTaskConfigs(List<SegmentZKMetadata> sel
return pinotTaskConfigs;
}
+ private Map<String, String> getPushTaskConfig(Map<String, String>
batchConfigMap, String downloadUrls) {
+ try {
+ String[] downloadURLList =
downloadUrls.split(MinionConstants.SEGMENT_NAME_SEPARATOR);
+ if (downloadURLList.length > 0) {
+ String downloadUrl = downloadURLList[0];
+ URI downloadURI = URI.create(downloadUrl);
+ URI outputDirURI = null;
+ if (!downloadURI.getScheme().contentEquals("http")) {
Review Comment:
If that's the goal, then we just need to use
`controllerConfig.getDataDir()/tableName`. What do you think?
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/BaseMultipleSegmentsConversionExecutor.java:
##########
@@ -242,6 +256,10 @@ public List<SegmentConversionResult>
executeTask(PinotTaskConfig pinotTaskConfig
new
BasicHeader(FileUploadDownloadClient.CustomHeaders.SEGMENT_ZK_METADATA_CUSTOM_MAP_MODIFIER,
segmentZKMetadataCustomMapModifier.toJsonString());
+ URI outputSegmentTarURI =
moveSegmentToOutputPinotFS(pinotTaskConfig.getConfigs(),
convertedTarredSegmentFile);
+ LOGGER.info("Moved generated segment from [{}] to location: [{}]",
Review Comment:
Personally, I think this may not be a problem. Because Minion task should be
idempotent, a later retry should generate segments with the same name and the
existing ones will be reused or be override.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
