KKcorps commented on code in PR #9825:
URL: https://github.com/apache/pinot/pull/9825#discussion_r1038164529
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java:
##########
@@ -67,7 +72,35 @@ static PinotFS getOutputPinotFS(Map<String, String>
taskConfigs, URI fileURI)
return PinotFSFactory.create(fileURIScheme);
}
- static PinotFS getLocalPinotFs() {
+ public static Map<String, String> getPushTaskConfig(String tableName,
Map<String, String> taskConfigs,
+ ClusterInfoAccessor clusterInfoAccessor) {
+ try {
+ URI outputDirURI = URI.create(clusterInfoAccessor.getDataDir() + "/" +
tableName);
Review Comment:
Cool. Made the changes. A lot of the code used here has been borrowed from
SegmentGenerationAndPushTask. I will also raise another PR to port some of
these changes from here to there.
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MergeRollupMinionClusterIntegrationTest.java:
##########
@@ -79,15 +81,18 @@ public class MergeRollupMinionClusterIntegrationTest
extends BaseClusterIntegrat
protected final File _segmentDir1 = new File(_tempDir, "segmentDir1");
protected final File _segmentDir2 = new File(_tempDir, "segmentDir2");
protected final File _segmentDir3 = new File(_tempDir, "segmentDir3");
+ protected final File _segmentDir4 = new File(_tempDir, "segmentDir4");
protected final File _tarDir1 = new File(_tempDir, "tarDir1");
protected final File _tarDir2 = new File(_tempDir, "tarDir2");
protected final File _tarDir3 = new File(_tempDir, "tarDir3");
+ protected final File _tarDir4 = new File(_tempDir, "tarDir4");
@BeforeClass
public void setUp()
throws Exception {
- TestUtils.ensureDirectoriesExistAndEmpty(_tempDir, _segmentDir1,
_segmentDir2, _segmentDir3, _tarDir1, _tarDir2,
- _tarDir3);
+ TestUtils.ensureDirectoriesExistAndEmpty(_tempDir,
Review Comment:
fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
