[GitHub] [pinot] gortiz commented on a diff in pull request #8979: optimize `order by sorted ASC, unsorted` and `order by DESC` cases

[GitBox]

gortiz commented on code in PR #8979:
URL: https://github.com/apache/pinot/pull/8979#discussion_r979756324


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java:
##########
@@ -162,7 +162,7 @@ protected void processSegments() {
         if (operator instanceof AcquireReleaseColumnsSegmentOperator) {
           ((AcquireReleaseColumnsSegmentOperator) operator).acquire();
         }
-        resultsBlock = (T) operator.nextBlock();
+        resultsBlock = convertToMergeableBlock((BaseResultsBlock) 
operator.nextBlock());

Review Comment:
   Good catch, but by simply changing `resultBlock` to `BaseResultsBlock` we 
cannot call `isQuerySatisfied` because it demands a `T`. I've applied some 
extra modifications, please check if they are good enough



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org