[GitHub] [pinot] gortiz commented on a diff in pull request #8979: optimize `order by sorted ASC, unsorted` and `order by DESC` cases

[GitBox]

gortiz commented on code in PR #8979:
URL: https://github.com/apache/pinot/pull/8979#discussion_r979823620


##########
pinot-core/src/main/java/org/apache/pinot/core/util/QueryOptionsUtils.java:
##########
@@ -102,4 +102,8 @@ public static boolean isNullHandlingEnabled(Map<String, 
String> queryOptions) {
   public static boolean isServerReturnFinalResult(Map<String, String> 
queryOptions) {
     return 
Boolean.parseBoolean(queryOptions.get(QueryOptionKey.SERVER_RETURN_FINAL_RESULT));
   }
+
+  public static boolean isSkipOrderByOptimization(Map<String, String> 
queryOptions) {
+    return Boolean.parseBoolean(queryOptions.getOrDefault("skip-order-by", 
"false"));

Review Comment:
   I've replaced it with a new enum option `order-by-algorithm`. The only 
literal right now is to apply the `naive` algorithm, which means to run with 
the brute force algorithm, but we could add more literals in the future to be 
treated as a hint or as a mandatory algorithm (which is very useful in 
benchmarks, but may be useful in case there is a bug in some algorithm).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org