gortiz commented on code in PR #8979:
URL: https://github.com/apache/pinot/pull/8979#discussion_r960736068
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/blocks/IntermediateResultsBlock.java:
##########
@@ -587,4 +600,101 @@ public BlockDocIdValueSet getBlockDocIdValueSet() {
public BlockMetadata getMetadata() {
throw new UnsupportedOperationException();
}
+
+ public static class ListSelection extends IntermediateResultsBlock {
Review Comment:
I still don't like this solution because we don't have any type safety when
ordered results are required. To be honest, I don't even like that the
comparator is stored in this class instead of being part of the combinator. But
I'm going to just add the comparator and pray for correctness in order to have
this merged sooner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
