somandal commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r974727536


##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TableConfig.java:
##########
@@ -58,6 +58,11 @@ public class TableConfig extends BaseJsonConfig {
   // Double underscore is reserved for real-time segment name delimiter
   private static final String TABLE_NAME_FORBIDDEN_SUBSTRING = "__";
 
+  // TODO: Remove this flag once the reload path to create forward index from 
inverted index and dictionary is
+  //       added. This feature will be disabled until the reload path is 
updated to handle forward index enable ->
+  //       disable and forward index disable -> enable.
+  public static boolean _disallowForwardIndexDisabled = true;

Review Comment:
   done



##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/metadata/ColumnMetadataImpl.java:
##########
@@ -348,6 +348,7 @@ public static class Builder {
     private PartitionFunction _partitionFunction;
     private Set<Integer> _partitions;
     private boolean _autoGenerated;
+    private boolean _forwardIndexDisabled;

Review Comment:
   oops, good point. done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to