siddharthteotia commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r988632936
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/column/PhysicalColumnIndexContainer.java:
##########
@@ -133,7 +133,11 @@ public
PhysicalColumnIndexContainer(SegmentDirectory.Reader segmentReader, Colum
_rangeIndex = null;
}
- PinotDataBuffer fwdIndexBuffer = segmentReader.getIndexFor(columnName,
ColumnIndexType.FORWARD_INDEX);
+ // Setting the 'fwdIndexBuffer' to null if forward index is enabled. No-op
index readers will be setup for the
Review Comment:
(nit) `typo enabled -> disabled`
> No-op index readers will be setup for the forward index disabled columns
...
This is no longer the case I guess since we changed approach and rely on
throwing exceptions. So might want to change the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
