somandal commented on code in PR #9333:
URL: https://github.com/apache/pinot/pull/9333#discussion_r974726960
##########
pinot-tools/src/main/java/org/apache/pinot/tools/segment/converter/DictionaryToRawIndexConverter.java:
##########
@@ -296,6 +297,10 @@ private void convertOneColumn(IndexSegment segment, String
column, File newSegme
throws IOException {
DataSource dataSource = segment.getDataSource(column);
ForwardIndexReader reader = dataSource.getForwardIndex();
+ if (reader == null) {
+ throw new UnsupportedEncodingException(String.format("Forward index is
disabled for column %s, cannot convert!",
Review Comment:
oops, that was meant to be an `UnsupportedOperationException`. I've modified
all of these to use the Preconditions.checkState() instead.
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -315,6 +341,19 @@ public List<String> getSortedColumns() {
return _sortedColumns;
}
+ /**
+ * For tests only.
+ */
+ @VisibleForTesting
+ public void setSortedColumns(String sortedColumn) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
