walterddr commented on code in PR #9064:
URL: https://github.com/apache/pinot/pull/9064#discussion_r927874972
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -120,14 +108,17 @@ public String toExplainString() {
protected TransferableBlock getNextBlock() {
try {
cumulateAggregationBlocks();
- return new TransferableBlock(toResultBlock());
+ return toResultBlock();
} catch (Exception e) {
return TransferableBlockUtils.getErrorTransferableBlock(e);
}
}
- private BaseDataBlock toResultBlock()
+ private TransferableBlock toResultBlock()
throws IOException {
+ if (_upstreamErrorBlock != null) {
Review Comment:
everything is correct, except for the transferableBlock with error
it will only send to the receiver that are originally expect from this
sender. not to everyone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
