siddharthteotia commented on code in PR #9064:
URL: https://github.com/apache/pinot/pull/9064#discussion_r927883985
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryDispatcher.java:
##########
@@ -118,6 +119,10 @@ public static List<DataTable>
reduceMailboxReceive(MailboxReceiveOperator mailbo
while (true) {
transferableBlock = mailboxReceiveOperator.nextBlock();
if (TransferableBlockUtils.isEndOfStream(transferableBlock)) {
+ if (transferableBlock.isErrorBlock()) {
Review Comment:
This does not look correct. The if condition at line 122 is inside the if
condition at line 121. How is it possible that a TransferableBlock is both a
EOS block and a error block ? Both are metadata block types but we still need
to distinguish between them ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
