siddharthteotia commented on code in PR #9064:
URL: https://github.com/apache/pinot/pull/9064#discussion_r927854853
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/AggregateOperator.java:
##########
@@ -143,36 +134,42 @@ private BaseDataBlock toResultBlock()
}
_isCumulativeBlockConstructed = true;
if (rows.size() == 0) {
- return DataBlockUtils.getEmptyDataBlock(_resultSchema);
+ return
TransferableBlockUtils.getEndOfStreamTransferableBlock(_resultSchema);
} else {
- return DataBlockBuilder.buildFromRows(rows, null, _resultSchema);
+ return new TransferableBlock(rows, _resultSchema,
BaseDataBlock.Type.ROW);
}
} else {
- return DataBlockUtils.getEndOfStreamDataBlock();
+ return
TransferableBlockUtils.getEndOfStreamTransferableBlock(_resultSchema);
}
}
private void cumulateAggregationBlocks() {
Review Comment:
(nit) suggest renaming this to `consumeInputBlocks` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
