siddharthteotia commented on code in PR #9064:
URL: https://github.com/apache/pinot/pull/9064#discussion_r927844278
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/WorkerQueryExecutor.java:
##########
@@ -100,38 +100,39 @@ public void runJob() {
}
// TODO: split this PhysicalPlanner into a separate module
+ // TODO: optimize this into a framework. (physical planner)
private BaseOperator<TransferableBlock> getOperator(long requestId,
StageNode stageNode,
Map<Integer, StageMetadata> metadataMap) {
- // TODO: optimize this into a framework. (physical planner)
if (stageNode instanceof MailboxReceiveNode) {
MailboxReceiveNode receiveNode = (MailboxReceiveNode) stageNode;
List<ServerInstance> sendingInstances =
metadataMap.get(receiveNode.getSenderStageId()).getServerInstances();
- return new MailboxReceiveOperator(_mailboxService,
RelDistribution.Type.ANY, sendingInstances, _hostName, _port,
- requestId, receiveNode.getSenderStageId());
+ return new MailboxReceiveOperator(_mailboxService,
receiveNode.getDataSchema(), RelDistribution.Type.ANY,
Review Comment:
Where do we do schema validation ? As in, if the receiver receives the
DataBlock but the schema sent as part of it by the sender stage is not same as
what receiver was expecting when stages were setup, then it should error out ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
