kkrugler commented on code in PR #8812:
URL: https://github.com/apache/pinot/pull/8812#discussion_r888296876
##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGenerationJobRunner.java:
##########
@@ -194,6 +199,23 @@ public void run()
filteredFiles.add(file);
}
}
+
+ // Sort files based on creation time.
+ Collections.sort(filteredFiles, new Comparator<String>() {
Review Comment:
Hmm, though I do see a `Collections.sort(siblingFiles);` on line 242,
wondering if that invalidates the previous sorting...
##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGenerationJobRunner.java:
##########
@@ -194,6 +199,23 @@ public void run()
filteredFiles.add(file);
}
}
+
+ // Sort files based on creation time.
+ Collections.sort(filteredFiles, new Comparator<String>() {
Review Comment:
Hmm, though I do see a `Collections.sort(siblingFiles);` on line 232,
wondering if that invalidates the previous sorting...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
