kkrugler commented on code in PR #8812:
URL: https://github.com/apache/pinot/pull/8812#discussion_r888170974
##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGenerationJobRunner.java:
##########
@@ -222,6 +229,15 @@ public void run()
}
}
_segmentCreationTaskCountDownLatch.await();
+
+ if (!_failures.isEmpty()) {
+ StringBuilder msg = new StringBuilder("Failed to generate Pinot
segment for file(s) - ");
+ _failures.forEach(p -> {
+ msg.append(msg.length() > 0 ? ", " : "");
Review Comment:
This code no longer exists, after I changed things to have a single
exception (fail fast) as per our discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
