kkrugler commented on code in PR #8812:
URL: https://github.com/apache/pinot/pull/8812#discussion_r890600654
##########
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGenerationJobRunner.java:
##########
@@ -253,6 +264,15 @@ private void submitSegmentGenTask(File localTempDir, URI
inputFileURI, int seqId
taskSpec.setFailOnEmptySegment(_spec.isFailOnEmptySegment());
taskSpec.setCustomProperty(BatchConfigProperties.INPUT_DATA_FILE_URI_KEY,
inputFileURI.toString());
+ // If there's already been a failure, log and skip this file. Do this
check right before the
+ // submit to reduce odds of starting a new segment when a failure is
recorded right before the
+ // submit.
+ if (_failure.get() != null) {
+ LOGGER.info("Skipping Segment Generation Task for {} due to previous
failures", inputFileURI);
+ _segmentCreationTaskCountDownLatch.countDown();
Review Comment:
Thanks, removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
